liuxiaocs7 commented on code in PR #8825:
URL: https://github.com/apache/hbase/pull/8825#discussion_r4439255151
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java:
##########
@@ -521,7 +521,7 @@ private void onComplete(HBaseRpcController controller,
ScanResponse resp) {
int numberOfCompleteRowsBefore = resultCache.numberOfCompleteRows();
try {
rawResults = ResponseConverter.getResults(controller.cellScanner(),
resp);
- updateResultsMetrics(scanMetrics, rawResults, isHeartbeatMessage);
+ updateResultsMetrics(scanMetrics, rawResults, regionServerRemote);
Review Comment:
The parameter is already named `isRegionServerRemote` in
`ConnectionUtils.updateResultsMetrics`, and the method does not use heartbeat
context. This PR fixes the caller incorrectly passing `isHeartbeatMessage`; the
method’s contract remains unchanged. The added tests cover both local and
remote servers with heartbeat and non-heartbeat responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
