Sigma-Ma commented on code in PR #172:
URL: https://github.com/apache/hbase-connectors/pull/172#discussion_r4450599547
##########
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableScanRDD.scala:
##########
@@ -182,9 +183,10 @@ class HBaseTableScanRDD(
filter: Option[SparkSQLPushDownFilter],
columns: Seq[Field]): Scan = {
val scan = (range.lower, range.upper) match {
- case (Some(Bound(a, b)), Some(Bound(c, d))) => new Scan(a, c)
+ case (Some(Bound(a, b)), Some(Bound(c, d))) =>
+ new Scan().withStartRow(a, b).withStopRow(c, d)
case (None, Some(Bound(c, d))) => new Scan(Array[Byte](), c)
Review Comment:
Thanks. In the current Spark 3 path, addRange() converts inclusive upper
bounds to exclusive bounds by appending 0x00, and region clipping also uses
exclusive upper bounds. So d is false here and <= is preserved. I'll still
switch this branch to new Scan().withStopRow(c, d) for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
