Sigma-Ma commented on code in PR #172:
URL: https://github.com/apache/hbase-connectors/pull/172#discussion_r4450611566
##########
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala:
##########
@@ -1142,6 +1142,31 @@ class RowKeyFilter(
result
}
+ // Normalize after the complete filter tree is built, before region pruning
and Get batching.
+ def normalize(): RowKeyFilter = {
+ val normalizedRanges = new mutable.MutableList[ScanRange]()
Review Comment:
This module builds with Scala 2.12.15, where MutableList is not deprecated.
The ranges field is also typed as MutableList, so replacing only this local
buffer with ListBuffer would not compile. I'd keep the existing collection type
here and leave a broader migration separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
