[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458432#comment-13458432
]
Lars Hofhansl commented on HBASE-6698:
--------------------------------------
Super minor nit:
{code}
+ Pair<Mutation, Integer> mutateWithLocks[] = new Pair[1];
+ mutateWithLocks[0] = new Pair<Mutation, Integer>(mutation, lid);
{code}
can be written as:
{code}
Pair<Mutation, Integer> mutateWithLocks[] = new Pair[] {new
Pair<Mutation, Integer>(mutation, lid)};
{code}
Also, this method should be marked with:
{{@SuppressWarnings("unchecked")}}
> Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
> ------------------------------------------------------------------
>
> Key: HBASE-6698
> URL: https://issues.apache.org/jira/browse/HBASE-6698
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
> Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
> HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
> HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch
>
>
> Currently the checkAndPut and checkAndDelete api internally calls the
> internalPut and internalDelete. May be we can just call doMiniBatchMutation
> only. This will help in future like if we have some hooks and the CP
> handles certain cases in the doMiniBatchMutation the same can be done while
> doing a put thro checkAndPut or while doing a delete thro checkAndDelete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
