[ https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458998#comment-13458998 ]
ramkrishna.s.vasudevan commented on HBASE-6698: ----------------------------------------------- Addressed Lar's comments in the latest patch. {code} + Delete delete = new Delete(new byte[0]); {code} Currently used in testcase only. We need a row object to obtain lock. Anyway changed it to use HConstants.EMPTY_BYTE_ARRAY. {code} doBatchMutate((Mutation)w, lid); {code} Cast is needed as w is of type Writable here. bq. This comment should be removed? Removed the comment. > Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation > ------------------------------------------------------------------ > > Key: HBASE-6698 > URL: https://issues.apache.org/jira/browse/HBASE-6698 > Project: HBase > Issue Type: Improvement > Reporter: ramkrishna.s.vasudevan > Fix For: 0.96.0 > > Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, > HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, > HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, > HBASE-6698_7.patch, HBASE-6698.patch > > > Currently the checkAndPut and checkAndDelete api internally calls the > internalPut and internalDelete. May be we can just call doMiniBatchMutation > only. This will help in future like if we have some hooks and the CP > handles certain cases in the doMiniBatchMutation the same can be done while > doing a put thro checkAndPut or while doing a delete thro checkAndDelete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira