[ 
https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459660#comment-13459660
 ] 

Harsh J commented on HBASE-6071:
--------------------------------

Nice patch. I'd prefer if we logged this at INFO itself though. This sorta 
retry is also known to kill remote bulkloads with tons of re-requests presently 
and we wouldn't know that if we didn't catch it via logs.

Secondly, it is tough on many older versions of Hadoop to enable DEBUG level 
logs in MR (where this (LE) is often reported from).
                
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6071
>                 URL: https://issues.apache.org/jira/browse/HBASE-6071
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, ipc
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Igal Shilman
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, 
> HBASE-6071.v3.patch, HConnectionManager_HBASE-6071-0.90.0.patch, 
> lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an 
> exception different then a DoNotRetryIOException, thus silently drops 
> exceptions from previous attempts.
> [~ted_yu] suggested 
> ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E])
>  adding a log message inside the catch block describing the exception type 
> and details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to