[
https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460433#comment-13460433
]
Hadoop QA commented on HBASE-6071:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546017/HBASE-6071.v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 139 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2915//console
This message is automatically generated.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch, HBASE-6071.v2.patch,
> HBASE-6071.v3.patch, HBASE-6071.v4.patch,
> HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an
> exception different then a DoNotRetryIOException, thus silently drops
> exceptions from previous attempts.
> [~ted_yu] suggested
> ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E])
> adding a log message inside the catch block describing the exception type
> and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
