[
https://issues.apache.org/jira/browse/HBASE-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460315#comment-13460315
]
ramkrishna.s.vasudevan commented on HBASE-6381:
-----------------------------------------------
@Jimmy
The fix for Rajesh's comment seems valid. I only have 2 questions
->Will these changes solve HBASE-6228 or do we still need to add some
synchronization while fixupdaughters?
->In GeneralBulkAssigner
{code}
while (regionInfoIterator.hasNext()) {
HRegionInfo hri = regionInfoIterator.next();
RegionState state = regionStates.getRegionState(hri);
if ((!regionStates.isRegionInTransition(hri) &&
regionStates.isRegionAssigned(hri))
|| state.isSplit() || state.isSplitting()) {
regionInfoIterator.remove();
{code}
This removal from regionInfoIterator may not be needed. Anyway SSH is handling
this case. And also as part of HBASE-6317 EnableTableHandler will handle RIT
regions and already assigned region.
In CreateTable this problem should not happen. So we can remove this piece of
code from GeneralBulkAssigner? what you feel?
Other than that I am +1. The ZKTable change can be done in a new JIRA as you
said.
> AssignmentManager should use the same logic for clean startup and failover
> --------------------------------------------------------------------------
>
> Key: HBASE-6381
> URL: https://issues.apache.org/jira/browse/HBASE-6381
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: hbase-6381-notes.pdf, hbase-6381.pdf,
> trunk-6381_v5.patch, trunk-6381_v7.patch, trunk-6381_v8.patch
>
>
> Currently AssignmentManager handles clean startup and failover very
> differently.
> Different logic is mingled together so it is hard to find out which is for
> which.
> We should clean it up and share the same logic so that AssignmentManager
> handles
> both cases the same way. This way, the code will much easier to understand
> and
> maintain.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
