[
https://issues.apache.org/jira/browse/HBASE-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460618#comment-13460618
]
Jimmy Xiang commented on HBASE-6381:
------------------------------------
@Ram, thanks a lot for the review. As to the removal from regionInfoIterator,
it is used locally to track unassigned regions so that we know if the bulk
assign is completed so I think it is needed.
As to HBASE-6228, I added the following to the fixupDaughters in HMaster before
actually fixing anything in order to avoid duplicated processing:
{noformat}
if (!serverManager.isServerDead(sn)) { // Otherwise, let SSH take care of
it
{noformat}
Here sn is the parent server name. So the chance of duplicated processing
should be very minimal, right?
> AssignmentManager should use the same logic for clean startup and failover
> --------------------------------------------------------------------------
>
> Key: HBASE-6381
> URL: https://issues.apache.org/jira/browse/HBASE-6381
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: hbase-6381-notes.pdf, hbase-6381.pdf,
> trunk-6381_v5.patch, trunk-6381_v7.patch, trunk-6381_v8.patch
>
>
> Currently AssignmentManager handles clean startup and failover very
> differently.
> Different logic is mingled together so it is hard to find out which is for
> which.
> We should clean it up and share the same logic so that AssignmentManager
> handles
> both cases the same way. This way, the code will much easier to understand
> and
> maintain.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
