[ 
https://issues.apache.org/jira/browse/HBASE-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462526#comment-13462526
 ] 

nkeywal commented on HBASE-6702:
--------------------------------

bq. What is this change?
I've changed the interface of the resource checker, but not yet removed 
ResourceCheckerJUnitRule, so I've just commented the removed methods.

bq. Whats this mean 'migrate the localTests to a newer version of surefire'?
The log lines don't show up with surefire 2.10. It works with my patched 
version. But the localTests profile uses the 2.10. It's historical: I've done 
it this way because we don't use categories nor parallelization for localTests.

The v2 should be "ready for commit' and will include your comments. Thanks for 
the review!
                
> ResourceChecker refinement
> --------------------------
>
>                 Key: HBASE-6702
>                 URL: https://issues.apache.org/jira/browse/HBASE-6702
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: nkeywal
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 6702.v1.patch
>
>
> This was based on some discussion from HBASE-6234.
> The ResourceChecker was added by N. Keywal to help resolve some hadoop qa 
> issues, but has since not be widely utilized. Further, with modularization we 
> have had to drop the ResourceChecker from the tests that are moved into the 
> hbase-common module because bringing the ResourceChecker up to hbase-common 
> would involved bringing all its dependencies (which are quite far reaching).
> The question then is, what should we do with it? Get rid of it? Refactor and 
> resuse? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to