[
https://issues.apache.org/jira/browse/HBASE-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463063#comment-13463063
]
Jesse Yates commented on HBASE-6702:
------------------------------------
Good stuff keywal! Just a couple comments:
{code}
+ <artifactId>hbase-common</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
{code}
To keep DRY, the aboves should go into hbase/pom.xml's dependencyManagement
section and then the children projects should just use:
{code}
+ <artifactId>hbase-common</artifactId>
+ <type>test-jar</type>
+ </dependency>
+ <dependency>
{code}
Also, any chance for some javadocs on things like:
{code}
+ public ResourceChecker(String tagLine) {
+ this.tagLine = tagLine;
+ }
{code}
Otherwise, this is a really sweet add.
> ResourceChecker refinement
> --------------------------
>
> Key: HBASE-6702
> URL: https://issues.apache.org/jira/browse/HBASE-6702
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: nkeywal
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6702.v1.patch, 6702.v4.patch
>
>
> This was based on some discussion from HBASE-6234.
> The ResourceChecker was added by N. Keywal to help resolve some hadoop qa
> issues, but has since not be widely utilized. Further, with modularization we
> have had to drop the ResourceChecker from the tests that are moved into the
> hbase-common module because bringing the ResourceChecker up to hbase-common
> would involved bringing all its dependencies (which are quite far reaching).
> The question then is, what should we do with it? Get rid of it? Refactor and
> resuse?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
