[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466067#comment-13466067
]
Ted Yu commented on HBASE-5937:
-------------------------------
Thanks Flavio for the effort.
For HLogUtil.java and HLogFactory.java:
{code}
+ * Copyright 2010 The Apache Software Foundation
{code}
Year is not needed.
{code}
+public class HLogUtil {
{code}
Please add class javadoc and annotation for audience.
In HLog interface, I see methods without javadoc:
{code}
+ public void registerWALActionsListener(final WALActionsListener listener);
+ public boolean unregisterWALActionsListener(final WALActionsListener
listener);
{code}
Please add javadoc for each of the interface methods: they're the first place
where developer / user looks at when they want to understand HLog.
For a 260KB patch, review board would help reviewers a lot.
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: HBASE-5937.patch, HBASE-5937.patch,
> org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
