[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466165#comment-13466165
]
Flavio Junqueira commented on HBASE-5937:
-----------------------------------------
Thanks for checking it out, Ted.
I checked the findbugs warnings, and I couldn't find anything related to this
patch, so the new patch I uploaded does not fix any findbugs warning.
bq. Year is not needed.
Sure, I have removed the three instances I found.
bq. Please add class javadoc and annotation for audience.
For this patch, I have simply copied the signatures of public methods to the
HLog interface. If there is no javadoc, it means that there was no javadoc for
the method implementation there before the patch. But, if you'd like us to
create them for this patch, I don't have a problem working on it. To be clear,
I'm just pointing out that it was not there before, and in general I agree they
should have javadocs.
bq. review board would help reviewers a lot.
Agreed, I tried to create a review request, but I'm getting an internal server
error right now, so I'll try later again. Hopefully it is a transient problem.
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch,
> org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
