[
https://issues.apache.org/jira/browse/HBASE-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468868#comment-13468868
]
Jean-Daniel Cryans commented on HBASE-6733:
-------------------------------------------
The log switching code really needs to be cleaned up, but my understanding is
that this patch won't do anything. {{processEndOfFile}} always sets the
{{currentPath}} to {{null}} so this:
{code}
+ Path oldPath = getCurrentPath();
{code}
would always return null in the case where we're switching log?
> [0.92 UNIT TESTS] TestReplication.queueFailover occasionally fails [Part-2]
> ---------------------------------------------------------------------------
>
> Key: HBASE-6733
> URL: https://issues.apache.org/jira/browse/HBASE-6733
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.92.3
>
> Attachments: 6733-1.patch, 6733-2.patch
>
>
> The failure is in TestReplication.queueFailover (fails due to unreplicated
> rows). I have come across two problems:
> 1. The sleepMultiplier is not properly reset when the currentPath is changed
> (in ReplicationSource.java).
> 2. ReplicationExecutor sometime removes files to replicate from the queue too
> early, resulting in corresponding edits missing. Here the problem is due to
> the fact the log-file length that the replication executor finds is not the
> most updated one, and hence it doesn't read anything from there, and
> ultimately, when there is a log roll, the replication-queue gets a new entry,
> and the executor drops the old entry out of the queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
