[ https://issues.apache.org/jira/browse/HBASE-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468909#comment-13468909 ]
Devaraj Das commented on HBASE-6733: ------------------------------------ The patch should continue to work if at some point of time, log switching behavior is changed so that the currentPath always points to a valid non-null path... But for now, yeah, null works as well (and I have checked in the Hadoop code that the implementation of equals method with a null argument is handled). > [0.92 UNIT TESTS] TestReplication.queueFailover occasionally fails [Part-2] > --------------------------------------------------------------------------- > > Key: HBASE-6733 > URL: https://issues.apache.org/jira/browse/HBASE-6733 > Project: HBase > Issue Type: Bug > Reporter: Devaraj Das > Assignee: Devaraj Das > Fix For: 0.92.3 > > Attachments: 6733-1.patch, 6733-2.patch > > > The failure is in TestReplication.queueFailover (fails due to unreplicated > rows). I have come across two problems: > 1. The sleepMultiplier is not properly reset when the currentPath is changed > (in ReplicationSource.java). > 2. ReplicationExecutor sometime removes files to replicate from the queue too > early, resulting in corresponding edits missing. Here the problem is due to > the fact the log-file length that the replication executor finds is not the > most updated one, and hence it doesn't read anything from there, and > ultimately, when there is a log roll, the replication-queue gets a new entry, > and the executor drops the old entry out of the queue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira