[
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-6943:
-------------------------------
Attachment: D5877.1.patch
mbautin requested code review of "[jira] [HBASE-6943] [89-fb] Do not catch
certain exceptions trying to get an RS connection".
Reviewers: Kannan, Liyin, Karthik, JIRA
When getting a regionserver connection in 0.89-fb in HBaseClient, we catch
all types of Throwable. I have observed a real case when the client looked
stuck. On debugging it turned out that a NoSuchMethodError was thrown and
caught, leaving the connection in an inconsistent state (initialized socket but
null streams). All following attempts resulted in NPEs that were also caught,
and no errors were logged. From the user's perspective the client was just
stuck. The root cause was the absence of a required jar (hence the
NoSuchMethodError) but it was not reported properly.
TEST PLAN
Run a client with the same configuration as before and verify it does not get
stuck.
REVISION DETAIL
https://reviews.facebook.net/D5877
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/13929/
To: Kannan, Liyin, Karthik, JIRA, mbautin
> [89-fb] Do not catch certain exceptions trying to get an RS connection
> ----------------------------------------------------------------------
>
> Key: HBASE-6943
> URL: https://issues.apache.org/jira/browse/HBASE-6943
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Attachments: D5877.1.patch
>
>
> When getting a regionserver connection in 0.89-fb in HBaseClient, we catch
> all types of Throwable. I have observed a real case when the client looked
> stuck. On debugging it turned out that a NoSuchMethodError was thrown and
> caught, leaving the connection in an inconsistent state (initialized socket
> but null streams). All following attempts resulted in NPEs that were also
> caught, and no errors were logged. From the user's perspective the client was
> just stuck. The root cause was the absence of a required jar (hence the
> NoSuchMethodError) but it was not reported properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
