[ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469537#comment-13469537
 ] 

Phabricator commented on HBASE-6943:
------------------------------------

Kannan has accepted the revision "[jira] [HBASE-6943] [89-fb] Do not catch 
certain exceptions trying to get an RS connection".

  lgtm! good catch...

REVISION DETAIL
  https://reviews.facebook.net/D5877

BRANCH
  stuck_client_v4

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc

                
> [89-fb] Do not catch certain exceptions trying to get an RS connection
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6943
>                 URL: https://issues.apache.org/jira/browse/HBASE-6943
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>         Attachments: D5877.1.patch
>
>
> When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
> all types of Throwable. I have observed a real case when the client looked 
> stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
> caught, leaving the connection in an inconsistent state (initialized socket 
> but null streams). All following attempts resulted in NPEs that were also 
> caught, and no errors were logged. From the user's perspective the client was 
> just stuck. The root cause was the absence of a required jar (hence the 
> NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to