[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474777#comment-13474777
]
stack commented on HBASE-6858:
------------------------------
If a BADVERSION, we first retry? Then if we get it again, then we fall into
the getData check? That seems good.
This is a random page,
http://www.javamex.com/tutorials/cryptography/pbe_salt.shtml, but its explicit
about one thing, something that seems right: "Never use a weak random number
generator such as java.util.Random to generate salt bytes!" It is probably
fine in this context but perhaps salt the call to new Random at least? What
can you stuff in there? Hash of the quorumServers passed in plus the hash of
the current instance?
This patch is only for trunk? Insertion of salt means that we won't be able to
do rolling upgrade? Not unless there are no regions in transition at the time?
Is that right?
> Fix the incorrect BADVERSION checking in the recoverable zookeeper
> ------------------------------------------------------------------
>
> Key: HBASE-6858
> URL: https://issues.apache.org/jira/browse/HBASE-6858
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
> HBASE-6858_v3.patch, trunk-6858.patch
>
>
> Thanks for Stack and Kaka's reporting that there is a bug in the recoverable
> zookeeper when handling BADVERSION exception for setData(). It shall compare
> the ID payload of the data in zk with its own identifier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
