[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475142#comment-13475142
]
Jimmy Xiang commented on HBASE-6858:
------------------------------------
Good point. I will replace it will SecureRandom.
If a BADVERSION, and we are not retrying, we should throw the exception, in
case other thread/caller set the same data the same version already.
I think we should check the data only if it is a retry after a connection issue.
I think the patch doesn't break rolling upgrade because, in retrieving data, we
use the dynamical id length from the data, not the static copy.
> Fix the incorrect BADVERSION checking in the recoverable zookeeper
> ------------------------------------------------------------------
>
> Key: HBASE-6858
> URL: https://issues.apache.org/jira/browse/HBASE-6858
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
> HBASE-6858_v3.patch, trunk-6858.patch
>
>
> Thanks for Stack and Kaka's reporting that there is a bug in the recoverable
> zookeeper when handling BADVERSION exception for setData(). It shall compare
> the ID payload of the data in zk with its own identifier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
