[
https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483385#comment-13483385
]
Ted Yu commented on HBASE-6721:
-------------------------------
In GroupAdminEndpoint:
{code}
+ throw new IOException(
+ "The region server or the target to move found to be null.");
{code}
It would be nice to point out which parameter is null.
{code}
+ throw new DoNotRetryIOException("Group must have no associated
tables.");
{code}
Include group name in the exception message.
{code}
+ public Map<String, String> listServersInTransition() throws IOException {
{code}
Return type of Map includes additional information which is not used by
callers. Suggest returning keySet.
Down in GroupAdminClient:
{code}
+ for(String server: proxy.listServersInTransition().keySet()) {
+ found = found || servers.contains(server);
+ }
{code}
Can you tell me what the body is supposed to achieve ?
Back to GroupAdminEndpoint:
{code}
+ private GroupInfoManager getGroupInfoManager() {
+ return
((GroupBasedLoadBalancer)menv.getMasterServices().getAssignmentManager().getBalancer()).getGroupInfoManager();
{code}
Does GroupInfoManager belong to balancer ? The above is probably the longest
indirection I have ever seen :-)
{code}
+ private List<HRegionInfo> getOnlineRegions(String hostPort) throws
IOException {
{code}
The above method is only called by listOnlineRegionsOfGroup() in a loop over
online servers, resulting in nested loop.
Please consider collapsing the nested loop into one loop.
{code}
+ LOG.error("Failed to complete GroupMoveServer with of
"+h.getPlan().getServers().size()+
{code}
nit: remove ' of ' in above sentence.
> RegionServer Group based Assignment
> -----------------------------------
>
> Key: HBASE-6721
> URL: https://issues.apache.org/jira/browse/HBASE-6721
> Project: HBase
> Issue Type: New Feature
> Reporter: Francis Liu
> Assignee: Vandana Ayyalasomayajula
> Fix For: 0.96.0
>
> Attachments: HBASE-6721_94.patch, HBASE-6721_94.patch,
> HBASE-6721-DesigDoc.pdf
>
>
> In multi-tenant deployments of HBase, it is likely that a RegionServer will
> be serving out regions from a number of different tables owned by various
> client applications. Being able to group a subset of running RegionServers
> and assign specific tables to it, provides a client application a level of
> isolation and resource allocation.
> The proposal essentially is to have an AssignmentManager which is aware of
> RegionServer groups and assigns tables to region servers based on groupings.
> Load balancing will occur on a per group basis as well.
> This is essentially a simplification of the approach taken in HBASE-4120. See
> attached document.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
