[
https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483498#comment-13483498
]
Ted Yu commented on HBASE-6721:
-------------------------------
{code}
+ public void beforeProcess(EventHandler event) {
{code}
I think normally the above should be called preProcess().
{code}
+ public void afterProcess(EventHandler event) {
{code}
Rename to postProcess().
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
The above is no longer needed in license header.
{code}
+public interface GroupAdminProtocol extends GroupAdmin, CoprocessorProtocol {
+}
{code}
I wasn't expecting a Protocol to not have methods in it :-)
{code}
+public class GroupBasedLoadBalancer implements LoadBalancer {
{code}
Add javadoc for GroupBasedLoadBalancer.
{code}
+ } catch (IOException e) {
+ LOG.warn("IOException while creating GroupInfoManagerImpl.", e);
+ }
{code}
I think if groupManager cannot be initialized, we should abort master because
group policy wouldn't be enforced.
In correctAssignments():
{code}
+ if ((info == null) || (!info.containsServer(sName.getHostAndPort()))) {
+ // Misplaced region.
+ misplacedRegions.add(region);
{code}
Under what scenario would a region be misplaced at runtime ? I think
rebalancing misplaced region(s) would affect normal operation of related groups.
{code}
+ //unassign misplaced regions, so that they are assigned to correct groups.
+ this.services.getAssignmentManager().unassign(misplacedRegions);
{code}
> RegionServer Group based Assignment
> -----------------------------------
>
> Key: HBASE-6721
> URL: https://issues.apache.org/jira/browse/HBASE-6721
> Project: HBase
> Issue Type: New Feature
> Reporter: Francis Liu
> Assignee: Vandana Ayyalasomayajula
> Fix For: 0.96.0
>
> Attachments: HBASE-6721_94.patch, HBASE-6721_94.patch,
> HBASE-6721-DesigDoc.pdf
>
>
> In multi-tenant deployments of HBase, it is likely that a RegionServer will
> be serving out regions from a number of different tables owned by various
> client applications. Being able to group a subset of running RegionServers
> and assign specific tables to it, provides a client application a level of
> isolation and resource allocation.
> The proposal essentially is to have an AssignmentManager which is aware of
> RegionServer groups and assigns tables to region servers based on groupings.
> Load balancing will occur on a per group basis as well.
> This is essentially a simplification of the approach taken in HBASE-4120. See
> attached document.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
