[
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486390#comment-13486390
]
Gregory Chanan commented on HBASE-4583:
---------------------------------------
I agree with your comments about making a common code path for the read/update
operations and in there we could decide if we want to do upserts each time.
The upsert argument is complicated because it's really a question of the read
workload as much as the write workload, but we have to decide at write-time w/o
much information (at least now as we don't collect statistics or anything).
Off the top of my head I could see upserts being more useful for increments
than puts, since increments are only holding numerical values (so old version x
is probably just the current version minus the usual increment amount times x).
Puts might have information you'd actually want to look at (job titles, times
of last submitted help-desk tickets,etc). This is very hand-wavy though.
So, I think I'd just keep the upsert functionality for now and make it MVCC
aware. We can revisit if/when we unify the implementations.
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
> Key: HBASE-4583
> URL: https://issues.apache.org/jira/browse/HBASE-4583
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 4583-trunk-radical.txt, 4583-trunk-radical_v2.txt,
> 4583-trunk-v3.txt, 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a
> client could see the results of multiple such operation mixed in the same
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes
> to and from the memstore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
