[
https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526026#comment-13526026
]
Jesse Yates commented on HBASE-7294:
------------------------------------
I'd like to see the cleaners added to hbase-default.xml and then have the
snapshot manager check to make sure that the correct cleaners are enabled on
startup (similar to how we cleanup the .snapshot/.tmp directory in HBASE-7240).
If the cleaners aren't enabled, we don't block startup, but instead prevent any
snapshots from being taken.
There is the consideration of 'what if there are existing snapshots'? The last
thing we want is unintentional data loss. Here we have two options: (1) fail
startup with an error message telling the user to remove the snapshots before
preceeding, or (2) add the snapshot cleaner back in.
I think (1) is the better case, but it also requires adding another
configuration option, specifiying the acceptable classes for snapshot cleaning.
A user might want to have their own policies for cleaning up files related to
snaphots (for instance, even if there is a snapshot, we want to remove the
files after 30 days, but otherwise don't remove them). By default, we don't
remove ANY files that are in a snapshot. (there also might be room here to make
a configurable policy for the snapshot file cleaners to take a TTL, but that
defaults to infinity, but that's probably a bit premature).
> Check for snapshot file cleaners on start
> -----------------------------------------
>
> Key: HBASE-7294
> URL: https://issues.apache.org/jira/browse/HBASE-7294
> Project: HBase
> Issue Type: Sub-task
> Components: Client, master, regionserver, snapshots, Zookeeper
> Affects Versions: hbase-6055
> Reporter: Jesse Yates
> Fix For: hbase-6055, 0.96.0
>
>
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not
> enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the
> user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the
> cleaner is not enabled?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
