[
https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535437#comment-13535437
]
Jonathan Hsieh commented on HBASE-7294:
---------------------------------------
seems like info level.
{code}
+ LOG.warn("Snapshot feature is not enabled, missing log and hfile
cleaners.");
{code}
slight reword of this
{code}
+ "To been able to use snapshots HBase Master must have cleaners
enabled. " +
{code}
to "To use snapshots, the HBase Master must have the proper archive cleaners
enabled."
Does this print out exactly what we want for these *.class? We want it to
print 'org.apache.hadoop.hbase....SnapshotHFileCleaner'. See
http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/Class.html#toString()
about the Class#toString method. I think you many need to make it
SnapshotHFileCleaner.getName() (or maybe it is getCanonicalName()).
{code}
+ "'hbase.master.hfilecleaner.plugins' with '" +
+ HFileLinkCleaner.class + "', '" + SnapshotHFileCleaner.class +
+ "' support. And add 'hbase.master.logcleaner.plugins' with '" +
{code}
> Check for snapshot file cleaners on start
> -----------------------------------------
>
> Key: HBASE-7294
> URL: https://issues.apache.org/jira/browse/HBASE-7294
> Project: HBase
> Issue Type: Sub-task
> Components: Client, master, regionserver, snapshots, Zookeeper
> Affects Versions: hbase-6055
> Reporter: Jesse Yates
> Assignee: Matteo Bertozzi
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7294-v1.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to
> ensure that any hfiles or hlogs (respectively) that are currently part of a
> snapshot are not removed from their respective archive directories (.archive
> and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not
> enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the
> user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the
> cleaner is not enabled?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
