[ 
https://issues.apache.org/jira/browse/HBASE-7303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526933#comment-13526933
 ] 

Harsh J commented on HBASE-7303:
--------------------------------

Thanks Elliot. I think this could be done using the compat modules. Would you 
have an example commit to show how to port it to load from compat? Should I, 
for example, place the HLog interface into general hadoop-compat module, and 
provide hadoop-1 and hadoop-2 implementations of FSHLog in their own modules? 
Or would FSHLog itself have to be an interface?
                
> Quit using reflection for the method DFSOutputStream#getNumCurrentReplicas(…)
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-7303
>                 URL: https://issues.apache.org/jira/browse/HBASE-7303
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>
> Given that we've raised our minimum version guarantee for HBase with 1.x 
> carrying the 0.20-append code finally, and all subsequent releases (0.21*, 
> 0.22, 0.23 and 2) have this method available in them, I don't see a reason to 
> have the reflection based getNumCurrentReplicas invocation (via HDFS-826) 
> anymore.
> We could save ourselves quite a bit of perf. penalty by removing this check 
> and simply calling the method directly, as its API has not changed across 
> releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to