[ 
https://issues.apache.org/jira/browse/HBASE-7303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526993#comment-13526993
 ] 

Andrew Purtell commented on HBASE-7303:
---------------------------------------

FSHLog is where we pull out FS specific logic, so my vote would be to move 
FSHLog to the compat modules, so version specific reflection can be converted 
into direct method calls, and leave HLog in hbase-server. 
                
> Quit using reflection for the method DFSOutputStream#getNumCurrentReplicas(…)
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-7303
>                 URL: https://issues.apache.org/jira/browse/HBASE-7303
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>
> Given that we've raised our minimum version guarantee for HBase with 1.x 
> carrying the 0.20-append code finally, and all subsequent releases (0.21*, 
> 0.22, 0.23 and 2) have this method available in them, I don't see a reason to 
> have the reflection based getNumCurrentReplicas invocation (via HDFS-826) 
> anymore.
> We could save ourselves quite a bit of perf. penalty by removing this check 
> and simply calling the method directly, as its API has not changed across 
> releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to