[
https://issues.apache.org/jira/browse/HBASE-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529711#comment-13529711
]
stack commented on HBASE-7233:
------------------------------
bq. Move the codec package up out of io package?
Yeah, could. Let me look. I was thinking codecs always going against stream
but you make a good point if we memstore it. Will fix codecexception too.
bq. Do we need both Encoder and CellOutputStream interfaces?
I don't follow unless you are saying I should just use COS in place of Encoder
... I had Encoder extend COS for a while. It could work. What to do about the
COS IOEs though? We'd have them bubble up through codec implementations?
On CellSearcher, I grabbed it but am not using it. Will drop from patch for
now. I want a random seeker Interface. This looks like it has what we'd need.
I was thinking a codec could implement the Decoder or CellScanner AND
CellSearcher. Would not be backed by a stream.
On CellScanner#next vs #read, yeah, I changed it to #read but actually thought
I'd put it back to #next. It was #read because I'd renamed CellScanner as
CellInputStream to match CellOutputStream... but then went back on myself.
Will fix.
bq. I wonder if it's time to ditch the separate disk/memory encoding feature as
I have a feeling people don't use it.
Not well enough versed to say whether or which. I like idea of simplifying but
at same time am afraid to touch and am more inclined to bump the hfile version
and start writing new hfiles w/ new encoders keeping around the old encoding
classes for reading legacy hfiles.
Ok on the vints... ugh, I just noticed we have vint'ing in Bytes class....
copied from WritableUtils... so could get byte arrays rather than streams.
Might use that. Will look around toooooo
Thanks for feedback. Yeah, I'm about rpc these times so good having differing
perspectives on this stuff.
> Serializing KeyValues
> ---------------------
>
> Key: HBASE-7233
> URL: https://issues.apache.org/jira/browse/HBASE-7233
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7233sketch.txt, 7233.txt, 7233-v2.txt,
> 7233v3_encoders.txt, 7233v4_encoders.txt
>
>
> Undo KeyValue being a Writable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
