[ 
https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534328#comment-13534328
 ] 

nkeywal commented on HBASE-7349:
--------------------------------

Yep, I actually used IntelliJ to detect the warnings, it seems maven asks for 
more. I will do an addendum.
About checking on a different branch, I would personally prefer to to save the 
3 minutes and keep/drive the javadoc errors to zero. It's a little bit extreme 
(especially as a return without comment shows up as an error), but in other 
cases a bad javadoc is not nice from a end user point of view.

                
> Jenkins build should compare trunk vs patch for Javadoc warnings
> ----------------------------------------------------------------
>
>                 Key: HBASE-7349
>                 URL: https://issues.apache.org/jira/browse/HBASE-7349
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>         Attachments: 7349-build-improve-javadoc-warnings.0.diff
>
>
> The javadoc check should look for an increase in the number of warnings. It 
> can do so by running javadoc against trunk before running it for the patch. 
> This will increase build times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to