[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536403#comment-13536403
]
nkeywal commented on HBASE-7390:
--------------------------------
Seems to be ok ok imho.
For testCloseByMasterWithoutZNode, it fails because we update the znode state
after doing the work. So when we discover there is no znode, the close is done.
It easy to fix by adding a test at the beginning of the close.
As a consequence:
- broken situation where we were calling a close without znode will now lead to
an error
- we will be a little bit slower, as we will have another zk sync & read on the
critical path
If we're in line with what was done by Jimmy Xiang previously (i.e. checking
carefully what we're doing :-) ), we should do it.
Toughts?
> Add extra test cases for assignement on the region server and fix the related
> issues
> ------------------------------------------------------------------------------------
>
> Key: HBASE-7390
> URL: https://issues.apache.org/jira/browse/HBASE-7390
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Fix For: 0.96.0
>
> Attachments: 7390.v1.patch, 7390.v2.patch, assignment_zk_states.jpg
>
>
> We don't have a lot of tests on the region server itself.
> Here are some.
> Some of them are failing, feedback welcome.
> See as well the attached state diagram for the ZK nodes on assignment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
