[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536508#comment-13536508
]
nkeywal commented on HBASE-7390:
--------------------------------
for the tests, we have the usual suspects again it seems.
[~sershe]
bq. One closeRegion throws, and the other returns false, to indicate the same
condition. Is this intended?
Yeah... Questionable but acceptable imho. Don't mind changing this, but then I
will need to throw an exception from the return somewhere else, and to change
the return type from boolean to a 3 states types (no state, same state,
different state).
bq. What is the RuntimeException here?
Over (and bad) design I would say. Changed.
bq "of", "expected"
Done.
> Add extra test cases for assignement on the region server and fix the related
> issues
> ------------------------------------------------------------------------------------
>
> Key: HBASE-7390
> URL: https://issues.apache.org/jira/browse/HBASE-7390
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Fix For: 0.96.0
>
> Attachments: 7390.v1.patch, 7390.v2.patch, 7390.v3.patch,
> 7390.v4.patch, assignment_zk_states.jpg
>
>
> We don't have a lot of tests on the region server itself.
> Here are some.
> Some of them are failing, feedback welcome.
> See as well the attached state diagram for the ZK nodes on assignment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
