[
https://issues.apache.org/jira/browse/HBASE-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541129#comment-13541129
]
Hadoop QA commented on HBASE-6393:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562722/HBASE-6393-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3769//console
This message is automatically generated.
> Decouple audit event creation from storage in AccessController
> --------------------------------------------------------------
>
> Key: HBASE-6393
> URL: https://issues.apache.org/jira/browse/HBASE-6393
> Project: HBase
> Issue Type: Brainstorming
> Components: security
> Affects Versions: 0.96.0
> Reporter: Marcelo Vanzin
> Attachments: hbase-6393-v1.patch, HBASE-6393-v2.patch
>
>
> Currently, AccessControler takes care of both generating audit events (by
> performing access checks) and storing them (by creating a log message and
> writing it to the AUDITLOG logger).
> This makes the logging system the only way to catch audit events. It means
> that if someone wants to do something fancier (like writing these records to
> a database somewhere), they need to hack through the logging system, and
> parse the messages generated by AccessController, which is not optimal.
> The attached patch decouples generation and storage by introducing a new
> interface, used by AccessController, to log the audit events. The current,
> log-based storage is kept in place so that current users won't be affected by
> the change.
> I'm filing this as an RFC at this point, so the patch is not totally clean;
> it's on top of HBase 0.92 (which is easier for me to test) and doesn't have
> any unit tests, for starters. But the changes should be very similar on trunk
> - I don't remember changes in this particular area of the code between those
> versions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
