[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541162#comment-13541162
]
stack commented on HBASE-7390:
------------------------------
Patch is great. You have two +1s up in RB. Here is another +1 from me... The
tests are great as are the comments.
You have lines > 100 characters according to the hadoopqa output!
This is no longer deprecated?
- * @deprecated use {@link #getRegionLocation(byte [], boolean)} instead
This should not be javadoc:
+ *
+ * Protected to ease testing.
Could be a comment inside the method.
Does it have to be this explicit type:
+ public ConcurrentSkipListMap<byte[], Boolean> getRegionsInTransitionInRS();
Can it be NavigableMap or SortedMap? (Not important).
> Add extra test cases for assignement on the region server and fix the related
> issues
> ------------------------------------------------------------------------------------
>
> Key: HBASE-7390
> URL: https://issues.apache.org/jira/browse/HBASE-7390
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Fix For: 0.96.0
>
> Attachments: 7390.v10.patch, 7390.v1.patch, 7390.v2.patch,
> 7390.v3.patch, 7390.v4.patch, 7390.v6.patch, 7390.v7.patch, 7390.v8.patch,
> 7390.v9.patch, 7390.v9.patch, assignment_zk_states.jpg
>
>
> We don't have a lot of tests on the region server itself.
> Here are some.
> Some of them are failing, feedback welcome.
> See as well the attached state diagram for the ZK nodes on assignment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
