[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541164#comment-13541164
]
nkeywal commented on HBASE-7390:
--------------------------------
bq. You have lines > 100 characters according to the hadoopqa output!
Hadoopqa is right :-). I will fix it on commit.
bq. This is no longer deprecated?
It was a little bit strange to have this one deprecated while the ones with two
parameters / same method name were not. So I thought it was better to
de-deprecate it.
bq. This should not be javadoc:
Hum, I thought it made sense to have it in the javadoc: someone using (vs.
developing) HBase would need to know that if a method is not private, it's not
because it's supposed to be used or extended, but only for internal testing.
bq. public ConcurrentSkipListMap<byte[], Boolean> getRegionsInTransitionInRS();
I kept the change even if iirc I finally don't need it for this patch. What was
useful was pure concurrent oriented stuff like functions putif-absent or
removeif-absent. So the best interface would be ConcurrentMap. I will change
this on commit. It's beyond the scope of this patch, but the RIT should be more
encapsulated, especially now that we sometimes hijack it to cancel an open...
This makes me think as well that the best implementation class would be
ConcurrentHashMap instead of ConcurrentSkipListMap. But's it will be for
another patch as well :-)
Thanks for the review, Stack, I will commit this tomorrow (and start to go
forward with the other jira I had on assignment: the depend on this one).
> Add extra test cases for assignement on the region server and fix the related
> issues
> ------------------------------------------------------------------------------------
>
> Key: HBASE-7390
> URL: https://issues.apache.org/jira/browse/HBASE-7390
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Fix For: 0.96.0
>
> Attachments: 7390.v10.patch, 7390.v1.patch, 7390.v2.patch,
> 7390.v3.patch, 7390.v4.patch, 7390.v6.patch, 7390.v7.patch, 7390.v8.patch,
> 7390.v9.patch, 7390.v9.patch, assignment_zk_states.jpg
>
>
> We don't have a lot of tests on the region server itself.
> Here are some.
> Some of them are failing, feedback welcome.
> See as well the attached state diagram for the ZK nodes on assignment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
