[ 
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543199#comment-13543199
 ] 

Ted Yu commented on HBASE-6669:
-------------------------------

There're empty lines in BigDecimalColumnInterpreter.java but not in 
TestBigDecimalColumnInterpreter.java

The license headers in both files don't look the same as in other source files.
When I tried to apply the patch:
{code}
p0 6669-v2.patch
patching file 
src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
patch: **** malformed patch at line 7: 
{code}
Have you tried using svn command to generate patch ?
Please remove the empty lines in patch.
                
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-6669
>                 URL: https://issues.apache.org/jira/browse/HBASE-6669
>             Project: HBase
>          Issue Type: New Feature
>          Components: Client, Coprocessors
>    Affects Versions: 0.94.3
>            Reporter: Anil Gupta
>            Priority: Minor
>              Labels: client, coprocessors
>             Fix For: 0.94.5
>
>         Attachments: BigDecimalColumnInterpreter.java, 
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch, 
> HBASE-6669.patch, HBASE-6669-v2.patch, TestBDAggregateProtocol.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values 
> stored as BigDecimal in HBase. I would like to commit the 
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used 
> by a wide variety of users. Please let me know if its not appropriate to add 
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to