[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543223#comment-13543223
]
Ted Yu commented on HBASE-7369:
-------------------------------
{code}
}
+ else if (connection.isClosed()) {
{code}
Move the 'else' line to the end of previous line.
{code}
+ close();
this.closed = true;
{code}
When we call close(), this.closed = true would be taken care of inside close(),
right ?
{code}
+ if(aborted){
+ HConnectionManager.deleteStaleConnection(this);
{code}
Please use two spaces for indentation. You can use
dev-support/hbase_eclipse_formatter.xml from trunk.
{code}
+ public void abortingHConnectionRemovesItFromHCM() throws Exception{
{code}
abortingHConnectionRemovesItFromHCM -> abortingHConnectionRemovesItselfFromHCM
{code}
+ Map<HConnectionKey, HConnectionImplementation> oldHBaseInstances = new
HashMap<HConnectionKey, HConnectionImplementation>();
+ for (Entry<HConnectionKey, HConnectionImplementation> entry :
HConnectionManager.HBASE_INSTANCES.entrySet()){
{code}
Wrap long line: 100 characters per line max
> HConnectionManager should remove aborted connections
> ----------------------------------------------------
>
> Key: HBASE-7369
> URL: https://issues.apache.org/jira/browse/HBASE-7369
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Affects Versions: 0.94.3
> Reporter: Bryan Baugher
> Priority: Minor
> Attachments: HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff,
> patch3.diff, patch.diff
>
>
> When an HConnection is abort()'ed (i.e. if numerous services are lost) the
> connection becomes unusable. HConnectionManager cache of HConnections
> currently does not have any logic around removing aborted connections
> automatically. Currently it is up to the consumer to do so using
> HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
