[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543419#comment-13543419
]
Ted Yu commented on HBASE-7369:
-------------------------------
{code}
- HConnectionManager.deleteConnection(this, stopProxy, false);
+ if(aborted){
{code}
nit: shift the if block left by two spaces (to align with the original position
of 'H').
{code}
+ }
+ else {
+ HConnectionManager.deleteConnection(this, stopProxy, false);
{code}
Move 'else {' to the end of previous line.
{code}
+ for (Entry<HConnectionKey, HConnectionImplementation> entry :
+ HConnectionManager.HBASE_INSTANCES.entrySet()) {
+ oldHBaseInstances.put(entry.getKey(), entry.getValue());
+ }
{code}
Utilize
http://docs.oracle.com/javase/6/docs/api/java/util/Map.html#putAll%28java.util.Map%29
for the two copy actions.
> HConnectionManager should remove aborted connections
> ----------------------------------------------------
>
> Key: HBASE-7369
> URL: https://issues.apache.org/jira/browse/HBASE-7369
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Affects Versions: 0.94.3
> Reporter: Bryan Baugher
> Priority: Minor
> Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
> HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
>
>
> When an HConnection is abort()'ed (i.e. if numerous services are lost) the
> connection becomes unusable. HConnectionManager cache of HConnections
> currently does not have any logic around removing aborted connections
> automatically. Currently it is up to the consumer to do so using
> HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
