[
https://issues.apache.org/jira/browse/HBASE-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547179#comment-13547179
]
Jimmy Xiang commented on HBASE-7516:
------------------------------------
Not a big deal, but wondering, can we call the existing policy
DefaultCompactionPolicy or something else, and make CompactionPolicy the actual
base?
{noformat}
- CompactionPolicy compactionPolicy;
+ CompactionPolicyBase<?> compactionPolicy;
{noformat}
The compactionPolicy has two abstract methods. How do you expect them to be
used? Where will the actually compaction algorithm logic be if
applyCompactionPolicy returns a CompactSelection? What's a CfgType?
{noformat}
+ protected abstract CfgType createCompactionConfiguration(Configuration
configuration,
+ StoreConfiguration storeConfig);
+
+ protected abstract CompactSelection applyCompactionPolicy(CompactSelection
candidates)
+ throws IOException;
{noformat}
Some javadoc will be very helpful. By the way, should we use RB for the next
patch?
[~sershe], thanks a lot for taking this issue.
> Make compaction policy pluggable
> --------------------------------
>
> Key: HBASE-7516
> URL: https://issues.apache.org/jira/browse/HBASE-7516
> Project: HBase
> Issue Type: Improvement
> Reporter: Jimmy Xiang
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7516-v0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
