[ 
https://issues.apache.org/jira/browse/HBASE-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551732#comment-13551732
 ] 

Sergey Shelukhin commented on HBASE-7516:
-----------------------------------------

I have left some comments in the /r/ and will come up with updated patch today.
With regard to level compaction and making more things pluggable.
Initially I just thought I will make Compactor pluggable and change its 
interface a bit (e.g. make it produce multiple files).
However, as I see now, with full leveldb compaction algorithm (with levels and 
overlapping ranges across levels), it will be insufficient - we'd need to 
change a some logic in HStore. Around compactions, obviously; storefiles list 
will also be suboptimal (all LevelDB algorithms work with levels, each of which 
except one have non-overlapping ranges; so selection from the list, while 
doable, is not pretty; various checks/logic relying on one sequence of files no 
longer make sense at all); also, StoreScanner file selection for scans will be 
different if we use ranges (ditto for gets). Other things may change too.

We can either fully refactor StoreFile management out or HStore (tempting), or 
do minimum abstraction when we already have implementation in mind.
In either case it will be in separate JIRA. I can try to do the former in 
another JIRA.
                
> Make compaction policy pluggable
> --------------------------------
>
>                 Key: HBASE-7516
>                 URL: https://issues.apache.org/jira/browse/HBASE-7516
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jimmy Xiang
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7516-v0.patch, HBASE-7516-v1.patch
>
>
> Currently, the compaction selection is pluggable. It will be great to make 
> the compaction algorithm pluggable too so that we can implement and play with 
> other compaction algorithms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to