[
https://issues.apache.org/jira/browse/HBASE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564860#comment-13564860
]
Ted Yu commented on HBASE-7521:
-------------------------------
{code}
+ * @return Pair that has all regionplans that pertain to this dead server
and a list that has
...
+ public Pair<Set<HRegionInfo>, List<RegionState>> processServerShutdown(final
ServerName sn) {
{code}
Better use term other than regionplan because the Set contains HRegionInfo's.
{code}
+ * @param deadServerRITs Regions that were in transition against the dead
server
+ * @return List of regions to assign or null if aborting.
+ * @throws IOException
+ */
+ private List<HRegionInfo> getRegionsToAssign(final NavigableMap<HRegionInfo,
Result> metaHRIs,
+ final List<RegionState> deadServerRITs, Set<HRegionInfo> regionsFromRIT)
throws IOException {
{code}
Please add javadoc for the new param - regionsFromRIT.
{code}
+ // Collect regions to bulk assign here.
{code}
The regions identified by getRegionsToAssign() are not bulk assigned - see line
298.
The comments below the above should be modified as well.
> fix HBASE-6060 (regions stuck in opening state) in 0.94
> -------------------------------------------------------
>
> Key: HBASE-7521
> URL: https://issues.apache.org/jira/browse/HBASE-7521
> Project: HBase
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7521-original-patch-ported-v0.patch,
> HBASE-7521-original-patch-ported-v1.patch, HBASE-7521-v0.patch,
> HBASE-7521-v1.patch
>
>
> Discussion in HBASE-6060 implies that the fix there does not work on 0.94.
> Still, we may want to fix the issue in 0.94 (via some different fix) because
> the regions stuck in opening for ridiculous amounts of time is not a good
> thing to have.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
