[ 
https://issues.apache.org/jira/browse/HBASE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568230#comment-13568230
 ] 

Matteo Bertozzi commented on HBASE-7603:
----------------------------------------

I think that if you want to merge it now to trunk, you should just do a 
refactor to move the code out, and to have the store ready for the future.

Having comments like this:
{code}// TODO: move this comment when implementing Level{code}
{code}// TODO [level compaction]: this will not work for level algo; need to 
move the decision into CompationPolicy{code}
bring me to the conclusion that probably this refactor is not enough to be 
future proof, and probably it will change again for stripe compaction or 
others. So why we should merge this code now, with no real use cases?

Think about having a level/stripe compaction branch and merge everything once 
you've defined the right interface.

I really want to see this stuff going in as soon as possible, but I'll like to 
see something that uses it.
                
> refactor storefile management in HStore in order to support things like 
> LevelDB-style compactions
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7603
>                 URL: https://issues.apache.org/jira/browse/HBASE-7603
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7603-v0.patch, HBASE-7603-v1.patch, 
> HBASE-7603-v2.patch, HBASE-7603-v2.patch, HBASE-7603-v3.patch, 
> HBASE-7603-v4.patch, HBASE-7603-v5.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to