[
https://issues.apache.org/jira/browse/HBASE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570497#comment-13570497
]
Ted Yu commented on HBASE-7603:
-------------------------------
Review board lags latest patch.
{code}
+class DefaultStoreFileManager implements StoreFileManager {
{code}
Please add audience annotation.
{code}
+ * Adds new file, either for from MemStore flush of bulk insert, into the
structure.
+ * @param sf New store file.
+ */
+ public abstract void insertNewFile(StoreFile sf);
{code}
I guess you wanted to say:
{code}
+ * Adds new file, either from MemStore flush or bulk insert, into the
structure.
{code}
The implementation appends the StoreFile to the end of list:
{code}
+ public void insertNewFile(StoreFile sf) {
+ ArrayList<StoreFile> newFiles = new ArrayList<StoreFile>(storefiles);
+ newFiles.add(sf);
{code}
And sorting in current codebase is gone:
{code}
- this.storefiles = sortAndClone(newFiles);
+ this.storeFiles.insertNewFile(sf);
{code}
Please explain.
> refactor storefile management in HStore in order to support things like
> LevelDB-style compactions
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-7603
> URL: https://issues.apache.org/jira/browse/HBASE-7603
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7603-v0.patch, HBASE-7603-v1.patch,
> HBASE-7603-v2.patch, HBASE-7603-v2.patch, HBASE-7603-v3.patch,
> HBASE-7603-v4.patch, HBASE-7603-v5.patch, HBASE-7603-v6.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
