[ 
https://issues.apache.org/jira/browse/HBASE-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582767#comment-13582767
 ] 

Jean-Marc Spaggiari commented on HBASE-7884:
--------------------------------------------

No.

compositeHash is initiated at hash1.
And At each iteration, composteHash receive hash2. So at each loop, 
compositeHash = hash1 + i * hash2.

Initial loop, compositeHash = hash1 = (hash1 + 0 * hash2)
Loop 2: compositeHash = hash1 + hash2 = (hash1 + 1 * hash2)
Loop 3: compositeHash = hash1 + hash2 + hash2 = (hash1 + 3 * hash2)

So composite is exactly the same as what you have in the original operation. No 
need to apply modulo on the last line.
                
> ByteBloomFilter's performance can be improved by avoiding multiplication when 
> generating hash 
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7884
>                 URL: https://issues.apache.org/jira/browse/HBASE-7884
>             Project: HBase
>          Issue Type: Bug
>          Components: Performance
>    Affects Versions: 0.94.5
>            Reporter: clockfly
>            Priority: Minor
>         Attachments: bloom_performance_tunning.patch
>
>
> ByteBloomFilter's performance can be optimized by avoiding multiplication 
> operation when generating hash 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to