[ 
https://issues.apache.org/jira/browse/HBASE-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583763#comment-13583763
 ] 

Nicolas Spiegelberg commented on HBASE-7884:
--------------------------------------------

clockfly: have you done perf comparisons?  When I looked into combinatorial 
hashing, I found that the Hash function strongly dominated perf and clarity was 
necessary everywhere else.  On a related note: 
http://stackoverflow.com/questions/1168451/is-shifting-bits-faster-than-multiplying-and-dividing-in-java-net
 .  I'm all for bit-math; but I have an embedded background, so x |= ~y; isn't 
complicated for me but may be for people looking through code @ 2am to fix a 
bug.
                
> ByteBloomFilter's performance can be improved by avoiding multiplication when 
> generating hash 
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7884
>                 URL: https://issues.apache.org/jira/browse/HBASE-7884
>             Project: HBase
>          Issue Type: Bug
>          Components: Performance
>    Affects Versions: 0.94.5
>            Reporter: clockfly
>            Priority: Minor
>             Fix For: 0.96.0, 0.94.6
>
>         Attachments: bloom_optimization_trunk_patch.patch, 
> bloom_performance_tunning.patch
>
>
> ByteBloomFilter's performance can be optimized by avoiding multiplication 
> operation when generating hash 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to