[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583568#comment-13583568
]
Ted Yu commented on HBASE-7899:
-------------------------------
{code}
+ * backing bytes copied from the steam.
{code}
Typo: steam
For CellTool:
{code}
+ public static CellScanner createCellScanner(final Iterator<Cell> cells) {
...
+ public boolean next() {
+ return this.iterator.hasNext();
+ }
{code}
Is the implementation for next() correct ?
{code}
+ public Cell getDeepCopy() {
+ // TODO: Fix to do a deep copy. Does the CellIterable passed have to
be against deep copies?
+ return get();
+ }
{code}
Do you plan to address the above in a follow-on issue ?
> Cell block building tools: Cell codec and means of iterating an objects Cells
> -----------------------------------------------------------------------------
>
> Key: HBASE-7899
> URL: https://issues.apache.org/jira/browse/HBASE-7899
> Project: HBase
> Issue Type: Task
> Components: IPC/RPC
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7899.txt
>
>
> In our rpc specification,
> https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
> we talk of passing lots of Cells outside of protobuf. We do it using Cell
> blocks. There are blobs filled with Cells that are encoded variously and
> optionally compressed.
> This issue is about adding to hbase-common basic facility for building Cell
> blocks. It includes a codec Interface for encoding/decoding Cell blocks as
> well as a means of iterating an objects Cell content (prefix-tree's
> CellScanner).
> This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
