[ 
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583575#comment-13583575
 ] 

Ted Yu commented on HBASE-7899:
-------------------------------

CellScannerable, Codec, BaseEncoder and BaseDecoder miss audience annotation.
{code}
[email protected]
[email protected]
+public final class CellTool {
{code}
I thought a Tool should be for public audience.
{code}
+     * @return Byte array read from the stream.
+     * @throws IOException
+     */
+    private byte [] readByteArray(final InputStream in) throws IOException {
{code}
Please add javadoc for parameter in.

                
> Cell block building tools: Cell codec and means of iterating an objects Cells
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-7899
>                 URL: https://issues.apache.org/jira/browse/HBASE-7899
>             Project: HBase
>          Issue Type: Task
>          Components: IPC/RPC
>            Reporter: stack
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7899.txt
>
>
> In our rpc specification, 
> https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
>  we talk of passing lots of Cells outside of protobuf.  We do it using Cell 
> blocks. There are blobs filled with Cells that are encoded variously and 
> optionally compressed.
> This issue is about adding to hbase-common basic facility for building Cell 
> blocks.  It includes a codec Interface for encoding/decoding Cell blocks as 
> well as a means of iterating an objects Cell content (prefix-tree's 
> CellScanner).
> This is a subtask of HBASE-7898 Serializing Cells over RPC

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to