[
https://issues.apache.org/jira/browse/HBASE-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585439#comment-13585439
]
Ted Yu commented on HBASE-7641:
-------------------------------
Overall patch looks good.
{code}
+public class BigDecimalColumnInterpreter extends ColumnInterpreter<BigDecimal,
BigDecimal, EmptyMsg, BigDecimalMsg, BigDecimalMsg> {
{code}
Please wrap long line - limit is 100 characters.
{code}
+
+ public BigDecimal getValue(byte[] colFamily, byte[] colQualifier, KeyValue kv)
{code}
Missing @Override
{code}
+ return (bd1 == null) ? bd2 : bd1; // either of one is null.
+ } else if (bd1 == null) // both are null
+ {
{code}
'else' is not needed above. Please put the '{' at the end of 'else if' line.
{code}
+ public BigDecimal castToReturnType(BigDecimal o) {
+ return o;
{code}
nit: some parameters are named bd, some o. Better be consistent.
For the test:
{code}
+ * @return
+ */
+ private static byte[][] makeN(byte[] base, int n) {
{code}
There're a lot of long lines in test, such as:
{code}
+ final ColumnInterpreter<BigDecimal, BigDecimal, EmptyMsg, BigDecimalMsg,
BigDecimalMsg> ci = new BigDecimalColumnInterpreter();
{code}
Please wrap.
> Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using
> AggregationClient' to trunk
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7641
> URL: https://issues.apache.org/jira/browse/HBASE-7641
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Labels: features, newbie, patch
> Attachments: BigDecimalColumnInterpreter.java, HBASE-7641.patch,
> hbase.proto, TestBigDecimalColumnInterpreter.java
>
>
> ColumnInterpreter implementation in trunk is different from that in 0.94
> This issue ports BigDecimalColumnInterpreter to trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
