[ 
https://issues.apache.org/jira/browse/HBASE-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585635#comment-13585635
 ] 

Ted Yu commented on HBASE-7641:
-------------------------------

Since TestConstraint is a medium test, the large tests were not executed in the 
above QA run.

Please use dev-support/hbase_eclipse_formatter.xml as formatter.
The indentation should be two spaces.
{code}
+               if (bd1 == null ^ bd2 == null) {
+                       return (bd1 == null) ? bd2 : bd1; // either of one is 
null.
+               } else if (bd1 == null) {
{code}
nit: there is no need for the 'else' keyword.
                
> Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using 
> AggregationClient' to trunk
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7641
>                 URL: https://issues.apache.org/jira/browse/HBASE-7641
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Julian Wissmann
>              Labels: features, newbie, patch
>             Fix For: 0.96.0
>
>         Attachments: BigDecimalColumnInterpreter.java, HBASE-7641.patch, 
> HBASE-7641v2.patch, hbase.proto, TestBigDecimalColumnInterpreter.java
>
>
> ColumnInterpreter implementation in trunk is different from that in 0.94
> This issue ports BigDecimalColumnInterpreter to trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to