[
https://issues.apache.org/jira/browse/HBASE-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589218#comment-13589218
]
Raymond Liu commented on HBASE-7952:
------------------------------------
Hi stack, thanks for review.
Strange, I don't see java doc warning in the second QA build, and the findbugs
warning is also not related. where did you find the two methods?
It can easily fake a test case to feed columns out of order to tracker by call
it directly, But I don't know any way to do this through StoreScanner.
StoreScanner will always have it ordered. So I am not sure a unit test case to
feed columns out of order is for what purpose? Do you mean we need an assert to
guard against this situation? Then it seems StoreScanner's next method already
check this. Do you think we need to double check this in columnTracker?
> Remove update() and Improve ExplicitColumnTracker performance.
> --------------------------------------------------------------
>
> Key: HBASE-7952
> URL: https://issues.apache.org/jira/browse/HBASE-7952
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.1, 0.94.5
> Reporter: Raymond Liu
> Assignee: Raymond Liu
> Fix For: 0.96.0
>
> Attachments: HBASE_7952.patch
>
>
> In ColumnTracker.java, the update() method is not used by anyone now. And no
> one will call checkColumn for different HFiles with update() in between files
> to re-walk through the target columns. All columns will be feed to
> checkColumn() in order.
> So, within ExplicitColumnTracker, the target columns can be optimized to not
> dynamic maintain a changing list of columns yet to match. Instead, just move
> index through it is enough.
> with this optimization to save the time for avoid reconstruct a columns array
> upon each row, the checkColumn method's performance could be improved by
> 10-20%.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
