[
https://issues.apache.org/jira/browse/HBASE-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589237#comment-13589237
]
Raymond Liu commented on HBASE-7952:
------------------------------------
Hi stack.
Thanks! good catch. I think the doc need to be modified a lot. when it mention
two type, it does not mention wildcardColumnTracker. And then, when it mention
two method, actually, it should be more than two, all the public method is
accessed by the ScanQueryMatcher. I think the doc is quite out of time.
And since this is not tightly related to the delete of update() but rather fix
of the doc, do you think we should do it in this patch or in separate patch?
And , for the guard, the StoreScanner.next() will do that:
{code}
379 // Check that the heap gives us KVs in an increasing order.
380 assert prevKV == null || comparator == null ||
comparator.compare(prevKV, kv) <= 0 :
381 "Key " + prevKV + " followed by a " + "smaller key " + kv + " in
cf " + store;
382 prevKV = kv;
383 ScanQueryMatcher.MatchCode qcode = matcher.match(kv);
{code}
I guess it is enough?
> Remove update() and Improve ExplicitColumnTracker performance.
> --------------------------------------------------------------
>
> Key: HBASE-7952
> URL: https://issues.apache.org/jira/browse/HBASE-7952
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.1, 0.94.5
> Reporter: Raymond Liu
> Assignee: Raymond Liu
> Fix For: 0.96.0
>
> Attachments: HBASE_7952.patch
>
>
> In ColumnTracker.java, the update() method is not used by anyone now. And no
> one will call checkColumn for different HFiles with update() in between files
> to re-walk through the target columns. All columns will be feed to
> checkColumn() in order.
> So, within ExplicitColumnTracker, the target columns can be optimized to not
> dynamic maintain a changing list of columns yet to match. Instead, just move
> index through it is enough.
> with this optimization to save the time for avoid reconstruct a columns array
> upon each row, the checkColumn method's performance could be improved by
> 10-20%.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
