[
https://issues.apache.org/jira/browse/HBASE-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589720#comment-13589720
]
Ted Yu commented on HBASE-7360:
-------------------------------
First of all since this JIRA is about backporting snapshots to 0.94, I would
expect the patch to align with the current formation in 0.95.
bq. I can understand the server having getCompletedSnapshots() but why we
expose it to the client?
{code}
/**
* List the currently available/stored snapshots. Any in-progress snapshots
are ignored
*/
@Override
public ListSnapshotResponse getCompletedSnapshots(RpcController controller,
{code}
Since in-progress snapshots are not exposed to client, API name was adjusted
for clarity.
bq. why the shell is still list_snapshots
Jonathan prefers list_snapshots during the review of HBASE-7290.
bq. Why the snapshot are treated differently from a table? listTables() vs
getCompletedSnapshots()
This question should be in the scope of HBASE-7290. Are you thinking of
changing the API in 0.95 and trunk ?
> Snapshot 0.94 Backport
> -----------------------
>
> Key: HBASE-7360
> URL: https://issues.apache.org/jira/browse/HBASE-7360
> Project: HBase
> Issue Type: New Feature
> Components: snapshots
> Affects Versions: 0.94.3
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.94.7
>
> Attachments: HBASE-7360-v0.patch
>
>
> Backport snapshot code to 0.94
> The main changes needed to backport the snapshot are related to the protobuf
> vs writable rpc.
> Offline Snapshot
> * HBASE-6610 - HFileLink: Hardlink alternative for snapshot restore
> * HBASE-6765 - Take a Snapshot interface
> * HBASE-6571 - Generic multi-thread/cross-process error handling framework
> * HBASE-6353 - Snapshots shell
> * HBASE-7107 - Snapshot References Utils (FileSystem Visitor)
> * HBASE-6863 - Offline snapshots
> * HBASE-6865 - Snapshot File Cleaners
> * HBASE-6777 - Snapshot Restore Interface
> * HBASE-6230 - Clone/Restore Snapshots
> * HBASE-6802 - Export Snapshot
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
